Mihai Cara

Results 196 comments of Mihai Cara

Changes to wcslib_wtbarr_wrap.c look good to me but I would like to see @larrybradley review on sigma clipping.

I understand. However my issue is with > this would at least allow the intended/desired behavior to be explicit "intended" and "desired" behavior is actually not _explicit_ from the "archival"...

I need to think about this. Even though I got tests to pass, I am not sure they should pass. I just need extra time to check everything.

Even though this is still a valid PR - we should not be loading SIP for non-celestial axes, its implementation will depend on the decision in https://github.com/astropy/astropy/issues/13105 here and so...

I also would like to add that currently time axis does not work well with -TAB due to a bug in WCSLIB. I am not sure what are all the...

Could you use https://github.com/astropy/astropy/blob/main/astropy/wcs/tests/data/tab-time-last-axis.fits ? Only 14KB. If you need `UTC` instead of `TIME`, you can edit the header.

It's not that hard if you use this: https://gwcs.readthedocs.io/en/latest/api/gwcs.wcs.WCS.html#gwcs.wcs.WCS.to_fits_tab Choose largest sampling possible - you do not need too many data points for a test. You could start with https://github.com/spacetelescope/gwcs/blob/713a0bc710a80ff44ac711ceec1f02ceb51d591c/gwcs/tests/conftest.py#L247-L282...

@hbushouse @nden This is ready for review. @stscieisenhamer no major changes were made since your review (mostly docs). I re-requested your review by accident.

> What happens if a user provides only a catalog for some (not all) of the input images? The code would use user-provided catalogs when provided and would use internal...