screencap icon indicating copy to clipboard operation
screencap copied to clipboard
verified publisher icon maxwell

Mostly updates for phantomjs 2.0 by DEfusion

Open jeremyk opened this issue 9 years ago • 5 comments

Also, a fix for deferring finding the screencap element until all resources have loaded. This fixes issues with client side rendering that depends on resource loading.

We are fine with having this as a fork but might help others to get it merged back into the main repo.

jeremyk avatar Mar 29 '16 18:03 jeremyk

im happy to merge. can we get the test fixed?

maxwell avatar Mar 31 '16 05:03 maxwell

Not really sure how the build is set up. Looks like ruby 2 passed where as before it was failing but the other 3 versions are dead and I don't think it has anything to do with what I did.

jeremyk avatar Apr 01 '16 00:04 jeremyk

Good work with the upgrade :+1:

The problem might be with change of version of the gem from 0.1.4 to 0.2.1.

basex avatar Apr 01 '16 13:04 basex

Yeah, I thought it might be that also but why is it only affecting one of the build versions? Makes me think it is a setting somewhere that I don't have access to.

jeremyk avatar Apr 01 '16 18:04 jeremyk

See PR#35 for a fix to this build issue.

steakunderscore avatar Apr 22 '16 16:04 steakunderscore