screencap icon indicating copy to clipboard operation
screencap copied to clipboard

Remove injection and dependency on jQuery

Open DEfusion opened this issue 10 years ago • 2 comments

For some reason the jQuery URL inject started not to load for me causing the callback to not run and the window to not be resized anymore. It isn't really needed for the things we were using it for so removed it and used DOM to do the same things.

DEfusion avatar Oct 09 '15 14:10 DEfusion

Interesting. I solve this in a slightly different way: https://github.com/ramen-dev/screencap/commit/24f6914333e2aef3cecf9c8ae8c25f4acc8b7e14

This lets me rely on the jQuery embedded in the if it exists & lets me override the URL.

ryana avatar Dec 16 '15 17:12 ryana

merge away!

maxwell avatar Feb 01 '16 06:02 maxwell