Sushi.Net icon indicating copy to clipboard operation
Sushi.Net copied to clipboard

Subtitle styles are broken

Open enter-a-random-username opened this issue 2 years ago • 3 comments

Color is missing and format has errors based on Validator (tried rescale-subtitles true/false - was no difference)

Before

[V4+ Styles]
Format: Name, Fontname, Fontsize, PrimaryColour, SecondaryColour, OutlineColour, BackColour, Bold, Italic, Underline, StrikeOut, ScaleX, ScaleY, Spacing, Angle, BorderStyle, Outline, Shadow, Alignment, MarginL, MarginR, MarginV, Encoding
Style: Default,Noto San,30,&H00FFFFFF,&H000000FF,&H00000000,&H501D0032,0,0,0,0,100,100,1,0,1,1.5,0,2,0,0,30,1

After Sushi.Net

[v4+ styles]
Format: Name, Fontname, Fontsize, PrimaryColour, SecondaryColour, OutlineColour, BackColour, Bold, Italic, Underline, StrikeOut, ScaleX, ScaleY, Spacing, Angle, BorderStyle, Outline, Shadow, Alignment, MarginL, MarginR, MarginV, Encoding
Style: Default,Noto Sans,30,&H00FFFFFF,&H000000FF,,&H501D0032,0,0,0,0,100,100,,0,1,1.5,0,2,0000,0000,0030,1

Issues

  • OutlineColour value is gone
  • Spacing value is gone (Validator - Skipping style value "" with non-numerical value for style field Spacing https://validator.subtitledpro.com/ )

enter-a-random-username avatar Dec 11 '23 12:12 enter-a-random-username

Yes, there is a problem, the current parser do not take in account the actual format line. But uses the more common one. Will fix.

El El lun, 11 dic. 2023 a la(s) 09:23, enter-a-random-username < @.***> escribió:

Color is missing and format has errors based on Validator (tried rescale-subtitles true/false - was no difference)

Before

[V4+ Styles] Format: Name, Fontname, Fontsize, PrimaryColour, SecondaryColour, OutlineColour, BackColour, Bold, Italic, Underline, StrikeOut, ScaleX, ScaleY, Spacing, Angle, BorderStyle, Outline, Shadow, Alignment, MarginL, MarginR, MarginV, Encoding Style: Default,Noto San,30,&H00FFFFFF,&H000000FF,&H00000000,&H501D0032,0,0,0,0,100,100,1,0,1,1.5,0,2,0,0,30,1

After Sushi.Net

[v4+ styles] Format: Name, Fontname, Fontsize, PrimaryColour, SecondaryColour, OutlineColour, BackColour, Bold, Italic, Underline, StrikeOut, ScaleX, ScaleY, Spacing, Angle, BorderStyle, Outline, Shadow, Alignment, MarginL, MarginR, MarginV, Encoding Style: Default,Noto Sans,30,&H00FFFFFF,&H000000FF,,&H501D0032,0,0,0,0,100,100,,0,1,1.5,0,2,0000,0000,0030,1

Issues

  • OutlineColour value is gone
  • Spacing value is gone (Validator - Skipping style value "" with non-numerical value for style field Spacing https://validator.subtitledpro.com/ )

— Reply to this email directly, view it on GitHub https://github.com/maxpiva/Sushi.Net/issues/10, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI4G3OG7QX6IMWG3G5X5SDYI33K5AVCNFSM6AAAAABAPVOF5GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTKNJWGEZTQOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

maxpiva avatar Dec 11 '23 14:12 maxpiva

I just ran into this issue as well. Is there a workaround other than copying back in the Styles section manually into each generated file?

Actually, that just seems to make the subtitles really small if the source is a different resolution from the destination file.

You'd need to copy over the Styles and replace these two lines in an ASS file with the original source resolution:

PlayResX: 640
PlayResY: 480

Sawtaytoes avatar Feb 07 '24 09:02 Sawtaytoes