php-debugbar icon indicating copy to clipboard operation
php-debugbar copied to clipboard

(WIP) Add GarbageCollector

Open barryvdh opened this issue 11 years ago • 5 comments

Initial commit, created BaseStorage with gc functions, updated the interface. Not really sure what the best place to run the GC would be.. Could be in the OpenHandler->handle() but that is only run on ajax/session requests. Could also call the checkGc() function after every save. (See #87)

Note: This is work in progress, not ready to merge yet..

barryvdh avatar Feb 12 '14 21:02 barryvdh

I omitted the getGcLifetime/Probability because I'm not sure why you would need them.

barryvdh avatar Feb 12 '14 21:02 barryvdh

This is where traits would have been useful, but I assume we are targeting php 5.3 still?

GrahamCampbell avatar Feb 12 '14 21:02 GrahamCampbell

indeed, PHP 5.3 is still the target. also, coding conventions :)

maximebf avatar Feb 12 '14 21:02 maximebf

Yeah I Will check them before merging, also need to do tests. But what do you think doing it like this? And where shall we run the gcCheck?

barryvdh avatar Feb 12 '14 21:02 barryvdh

What's the latest on this?

I've just switched to the PDO storage driver, as using headers is getting too large for Nginx, and the file driver is creating so many JSON files that Vagrant is beginning to struggle.

In any case, loving the debugbar.

ilumos avatar Feb 23 '19 15:02 ilumos