php-debugbar icon indicating copy to clipboard operation
php-debugbar copied to clipboard

Removed redundant calls to $this->template in TraceableTwigTemplate

Open OhMyMndy opened this issue 7 years ago • 3 comments

Removed redundant calls (they are catched by __call) to $this->template in TraceableTwigTemplate to remove the following incompatibility warning:

Declaration of DebugBar\Bridge\Twig\TraceableTwigTemplate::hasBlock() should be compatible with Twig_Template::hasBlock($name, array $context = NULL, array $blocks = Array)

OhMyMndy avatar May 02 '18 13:05 OhMyMndy

Doesn't this fail the interface implementation?

barryvdh avatar May 07 '18 09:05 barryvdh

Fortunately not, see the interface for 1.x Version 2.x does not have that interface and has an abstract class instead

OhMyMndy avatar May 14 '18 07:05 OhMyMndy

Can someone rerun the checks, because the checks failed on PHP 5.3 and PHP 5.4 which have been removed from Travis recently.

OhMyMndy avatar Jun 25 '18 08:06 OhMyMndy