Max Boone
Max Boone
Good write-up @maxfierrog and good points! My main request would be to first add support for MPI so that bend scripts can be easily adapted to run on large clusters...
> Hi, is there any update in this PR? I'm waiting for this feature My bad, I had a lot of other work to attend to. Will pick this up...
@tobz thanks a ton for the feedback, I think I processed everything but this is a first real rust contribution for me so apologies for it being messy here and...
@tobz I'll pick up the things that turn up from the CI tomorrow morning, if there's anything else lmk! With regards to some of the errors, does it help if...
@tobz any news here, please lmk if I can do anything!
> LGTM overall, but it still needs a changelog entry. @tobz Will do, thanks a ton for the review!
@tobz added the changelog entry, should be good to go :)
@pront @tobz I see some CI failing, is there something I can change / update (or extend the tests and run integration tests on my end)? I haven't tested it...
> It looks like the integration tests are failing to compile. You should be able to get the same errors locally by running `make check-clippy`. You can also run the...
I see some messages popping up from running clippy and the integration tests here. I really thought I had fixed those but reality seems different. I'll fix this in the...