MAVSDK-Python icon indicating copy to clipboard operation
MAVSDK-Python copied to clipboard

Simplify logging of mavsdk_server output

Open EricPedley opened this issue 2 years ago • 2 comments

Motivation

In #585 I described how logging output from the child process for mavsdk_server at only debug level hides useful errors from the user.

Summary

This PR removes the logic for redirecting the subprocess stdout to the debugger and results in the mavsdk_server child process's stdout and stderr going straight to the main stdout/stderr.

EricPedley avatar Apr 24 '23 08:04 EricPedley

What about making it an option?

Yeah this is a good idea. I added another parameter to System.connect that lets users turn off this logging.

EricPedley avatar Apr 25 '23 05:04 EricPedley

I think we should try to fix what was done in #370 (if it is indeed broken) instead :thinking:

JonasVautherin avatar Apr 25 '23 07:04 JonasVautherin

@EricPedley sorry, I didn't merge this but I hope what I did in https://github.com/mavlink/MAVSDK-Python/pull/781 - released in 3.9.0 - works for you. If you could test it and report back whether it works for you, that would be fantastic.

julianoes avatar Aug 01 '25 19:08 julianoes