libbf icon indicating copy to clipboard operation
libbf copied to clipboard

Incorrect header inclusion

Open lrobidou opened this issue 4 years ago • 0 comments

Hello,

I have some trouble installing libbf. After doing:

./configure
make
make install

libbf is installed here:

> tree /usr/local/include/            
/usr/local/include/
├── bf
│   ├── all.hpp
│   ├── bitvector.hpp
│   ├── bloom_filter
│   │   ├── a2.hpp
│   │   ├── basic.hpp
│   │   ├── bitwise.hpp
│   │   ├── counting.hpp
│   │   └── stable.hpp
│   ├── bloom_filter.hpp
│   ├── counter_vector.hpp
│   ├── h3.hpp
│   ├── hash.hpp
│   ├── object.hpp
│   └── wrap.hpp

I cant find the file bf.h specified in the current readme. In fact :

#include <bf.h>

int main(){
    bf::bloom_filter* h;
    return 0;
}

does not work, neither do :

#include <bf/bf.h>

int main(){
    bf::bloom_filter* h;
    return 0;
}

However,

#include <bf/all.hpp>

int main(){
    bf::bloom_filter* h;
    return 0;
}

does work, as specified in https://github.com/mavam/libbf/issues/32

1 - Should I open a merge request to update the readme ?

I have to install a project that uses libbf, and that project does: #include <bf.h> But it does not specify which version of libbf was used.

2 - Do you know if a previous version of libbf could be installed by including bf.h ? In such case, which version is it ?

I also used libbf in one of my project, and it worked great ! Thank you for your library.

lrobidou avatar May 11 '21 08:05 lrobidou