added BUILD_TESTS cmake option

Open mristin opened this issue 7 years ago • 1 comments

Dec 11 '18 06:12 mristin

Hi @mavam Sorry, it slipped my attention that there is a configure script. I would really suggest to remove the script (I didn't even notice that it exists ;)). I'm used to either configure && make && make install workflow or cmake ... && make && make install, but not a hybrid approach. As far as I can see, you set only some flags in configure which you could just as well set when invoking cmake (and this would also be the expected way of configuring for me)?

Since today so many people started using conan, it makes only sense to me to keep CMakeLists.txt, delete configure and package the whole repo for conan once we are satisfied with the changes (e.g., once the serialization is in). That would be the least surprise to me as the user.

Dec 19 '18 21:12 mristin