mtheme icon indicating copy to clipboard operation
mtheme copied to clipboard

Fix make uninstall

Open ntadej opened this issue 9 years ago • 4 comments

The double quotes in make uninstall prevented rm from working properly at least on OS X

ntadej avatar Oct 21 '16 12:10 ntadej

Why do you want to uninstall it? Metropolis is awesome. :smile:

benjamin-weiss avatar Oct 21 '16 13:10 benjamin-weiss

Besides the reason given by @benjamin-weiss, we should look for another solution because of more severe implications: The quotes were introduced because passing directory name with spaces in them might delete unrelated directories.

matze avatar Oct 21 '16 14:10 matze

@benjamin-weiss I made a personal fork with some changed colors and defaults, so I renamed it and wanted to test if makefile still works 😊

@matze The current uninstall does not work. I can try iterating over the files and appending path to each one, but I'm not very fluent in make.

ntadej avatar Oct 21 '16 15:10 ntadej

What if we just add quotes to the problematic directory strings? That is, instead of adding quotes to each command in make uninstall, we define

DESTDIR ?= "$(shell kpsewhich -var-value=TEXMFHOME)"

instead of

DESTDIR ?= $(shell kpsewhich -var-value=TEXMFHOME)

I think this should properly escape the things that need to be escaped without breaking the uninstall script.

rchurchley avatar Nov 02 '16 05:11 rchurchley