pdblp icon indicating copy to clipboard operation
pdblp copied to clipboard

ENH: Allow arbitrary date formats

Open ludaavics opened this issue 6 years ago • 3 comments

When generating dates dynamically I've found it tedious to convert the objects to the required format.

  • [X] Added test cases with various date formats. All the tests pass with two exceptions, test_bulkref_two_ticker_one_field and test_bsrch. However, these tests currently fail in the main branch as well
  • [X] passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • [X] whatsnew entry

ludaavics avatar Nov 21 '19 13:11 ludaavics

Thanks @ludaavics, will review when I get some free time.

matthewgilbert avatar Nov 21 '19 23:11 matthewgilbert

hi @matthewgilbert -- just checking if you have any issue with the pr?

Thanks!

ludaavics avatar Jul 19 '20 23:07 ludaavics

@ludaavics thanks for the PR. I reviewed it but I think a big change to the public facing API (even though this should be backwards compatible) is not something I want to introduce into the library at this point. I think this type of behaviour could be supported via decorators, so that is one option for supporting the behaviour in your own applications.

matthewgilbert avatar Jul 21 '20 15:07 matthewgilbert