JSONCodable icon indicating copy to clipboard operation
JSONCodable copied to clipboard
verified publisher icon matthewcheok

Xcode 9.1 & Swift 4 support

Open mokagio opened this issue 8 years ago • 4 comments

This PR upgrades the project to be in line with Xcode 9.1 and Swift 4.

mokagio avatar Nov 12 '17 10:11 mokagio

I am wondering what's the plan for this. Because as far as I know, Swift 4 already have native support for JSON encoding and decoding.

yzhong52 avatar Feb 22 '18 22:02 yzhong52

@yzhong52 my 2 cents. I use this library in a side project that is live in the Store. I don't have much time to spend on that project, moving to Swift's native Codable has little return of investment for me right now. That's why I forked the library to add Swift 4 support, so that I could still use it in that project without having to spend time migrating stuff that works already.

mokagio avatar Mar 22 '18 05:03 mokagio

And looking at your diff, there is no code change at all for Swift 4?

yzhong52 avatar Mar 23 '18 01:03 yzhong52

@mokagio also it looks like the build doesn't pass with your changes. https://travis-ci.org/matthewcheok/JSONCodable/builds/300894536

yzhong52 avatar Apr 03 '18 16:04 yzhong52