DefenderCheck icon indicating copy to clipboard operation
DefenderCheck copied to clipboard
verified publisher icon matterpreter

Cleaning up this tool and making it more performant in regards to byt…

Open ManEelyMan opened this issue 2 years ago • 2 comments

…e array copying.

ManEelyMan avatar Feb 27 '23 22:02 ManEelyMan

Thanks for the PR! Do you have performance stats? I'm curious to see how expensive the array copies are.

matterpreter avatar Mar 22 '23 15:03 matterpreter

No problem! A couple things:

  1. I originally meant for this to be PR'ed into my main branch not here, but when I saw I PR'ed to your repo, I figured I'd leave it in the off chance you found it helpful. :) Since it was meant for personal use, I didn't necessarily "play nice" with it and removed some extra things (like debug statements) I'm sure you want around just to have cleaner (IMO) code.
  2. I don't have any performance stats. I'd wager byte-handling is considerably faster by eliminating most in-memory copies, but the reality is that the bottleneck in this entire process is going to be invoking the MpCmdRun.exe, making these optimizations overall inconsequential. :) However, as per item number 1, above, I did this for my OCD. :P

ManEelyMan avatar Mar 22 '23 15:03 ManEelyMan