mattermost-plugin-github icon indicating copy to clipboard operation
mattermost-plugin-github copied to clipboard

--exclude functionality is missing validation that prevents user creating subscriptions that contradict each other

Open DHaussermann opened this issue 4 years ago • 1 comments

Currently it seems that users would be able to subscribe to a repo but then also subscribe to the organization with an --exclude to the same repo. This configuration should be invalid and we should prevent saving this data.

Case 1: When adding a subscription for owner/repo check if an --exclude exists already for a matching owner/repo Case 2: When adding a subscription for owner or org with an --exclude for a owner/repo check if an existing subscription exists for the owner/repo already

DHaussermann avatar Jan 17 '22 19:01 DHaussermann

this issue is fixed in this branch https://github.com/demansoltech/mattermost-plugin-github/tree/mm-494

sanjaydemansol avatar Jan 26 '22 10:01 sanjaydemansol

@DHaussermann @sanjaydemansol Is there anything left on this issue to do or we can close this.

Kshitij-Katiyar avatar Oct 05 '23 09:10 Kshitij-Katiyar

@Kshitij-Katiyar I think we can close the issue

hanzei avatar Oct 09 '23 11:10 hanzei