Subscriptions --exclude functionality affects all channels

[DHaussermann]

When using the exclude functionality the exclusion record that get's created owner/repo - notification : disabled is not channel specific. These exclusions appear in channels where no subscriptions have been created yet and no exclusion was specified.

This affects event delivery in channel --exclude was never used and prevents events from being delivered for some of the repositories. Steps:

• Create a subscription where an owner is passed in and exclude a repo /github subscriptions add DylanH20 --exclude DylanH20/Hello-World-1
• Test and note that events are delivered to the channel for all repos under DylanH20 except for Hello-World-1 (as expected)
• Create a new channel
• Type /github subscribe list notice DylanH20/Hello-World-1 - notification : disabled is already showing
• Type /github subscriptions add DylanH20 to subscribe to all repos underDylanH20

Observed Exclusion of Hello-World-1 affects newly created channel

[DHaussermann]

This seems to come from https://github.com/mattermost/mattermost-plugin-github/pull/457 @hanzei and @aaronrothschild I feel this issue should block the release as user can unintentionally impact subscriptions if they tray using the new --exclude functionality.

[Kshitij-Katiyar]

@DHaussermann @mickmister I tried reproducing the error but couldn't. The steps I have followed:

1. Created an org-level subscription excluding a repo in one channel.
2. Ran the /github subscription list in another channel but got the Currently there are no subscriptions in this channel. Below are the screenshots:

Can you please some additional steps in regards to this.

[AayushChaudhary0001]

@DHaussermann I tried to reproduce the issue by executing the steps provided, but I am not able to do so. The message received shows as follows:

cc: @Kshitij-Katiyar

[Kshitij-Katiyar]

@mickmister I think we can close this issue as it is not reproducible.

[mickmister]

Yeah I think this was explicitly fixed in a PR a while ago