[gh-438] create issue modal should disable the modals instead of hiding the modal itself.
Summary
Fixes #438 The modal will hide the repo name label when an issue is created
Ticket Link
#438
Hello @maisnamrajusingh,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Codecov Report
Merging #476 (dd8da3d) into master (86db5ca) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #476 +/- ##
=======================================
Coverage 15.54% 15.54%
=======================================
Files 15 15
Lines 4143 4143
=======================================
Hits 644 644
Misses 3457 3457
Partials 42 42
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 86db5ca...dd8da3d. Read the comment docs.
@sanjaydemansol Would you like to review this? It looks like you self-requested your review and then cancelled it
@sanjaydemansol Would you like to review this? It looks like you self-requested your review and then cancelled it
@mickmister , I am the author of this commit/branch. I assigned myself to subscribe for notifications on the same. But later thought, adding myself as Assignee is better.
I am the author of this commit/branch. I assigned myself to subscribe for notifications on the same. But later thought, adding myself as Assignee is better.
That's a bit confusing because @maisnamrajusingh submitted the PR. Maybe he should review then?
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook
@DHaussermann to re-pro issue where repo is not shoving on the create when org lock in place.
/update-branch
We don't have permissions to update this PR, please contact the submitter to apply the update.
@dipak-demansol @DHaussermann Is this PR ready to be merged?
@dipak-demansol @DHaussermann Is this PR ready to be merged?
@hanzei can you pls update this master branch with original master using the /update-branch, then will check the issue that i mentioned here https://github.com/mattermost/mattermost-plugin-github/pull/476#issuecomment-981661785 and then will update you about that ASAP.
Looks like you don't have permissions to trigger this command. Only available for the PR submitter and org members
/update-branch
We don't have permissions to update this PR, please contact the submitter to apply the update.
@maisnamrajusingh Would you please merge master into this branch?
I have fixed the linting errors so the PR looks ok for a merge pending final QA
@maisnamrajusingh in create issue model after selecting the repo, Description data is removed. pls fix that issue.
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!