mattermost-plugin-github icon indicating copy to clipboard operation
mattermost-plugin-github copied to clipboard

[gh-438] create issue modal should disable the modals instead of hiding the modal itself.

Open maisnamrajusingh opened this issue 4 years ago • 18 comments

Summary

Fixes #438 The modal will hide the repo name label when an issue is created

Ticket Link

#438

maisnamrajusingh avatar Aug 26 '21 10:08 maisnamrajusingh

Hello @maisnamrajusingh,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Aug 26 '21 10:08 mattermod

Codecov Report

Merging #476 (dd8da3d) into master (86db5ca) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #476   +/-   ##
=======================================
  Coverage   15.54%   15.54%           
=======================================
  Files          15       15           
  Lines        4143     4143           
=======================================
  Hits          644      644           
  Misses       3457     3457           
  Partials       42       42           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86db5ca...dd8da3d. Read the comment docs.

codecov-commenter avatar Aug 26 '21 10:08 codecov-commenter

@sanjaydemansol Would you like to review this? It looks like you self-requested your review and then cancelled it

mickmister avatar Aug 26 '21 15:08 mickmister

@sanjaydemansol Would you like to review this? It looks like you self-requested your review and then cancelled it

@mickmister , I am the author of this commit/branch. I assigned myself to subscribe for notifications on the same. But later thought, adding myself as Assignee is better.

sanjaydemansol avatar Aug 26 '21 15:08 sanjaydemansol

I am the author of this commit/branch. I assigned myself to subscribe for notifications on the same. But later thought, adding myself as Assignee is better.

That's a bit confusing because @maisnamrajusingh submitted the PR. Maybe he should review then?

mickmister avatar Aug 26 '21 15:08 mickmister

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

mattermod avatar Oct 02 '21 01:10 mattermod

@DHaussermann to re-pro issue where repo is not shoving on the create when org lock in place.

dipak-demansol avatar Nov 29 '21 14:11 dipak-demansol

/update-branch

DHaussermann avatar Dec 02 '21 14:12 DHaussermann

We don't have permissions to update this PR, please contact the submitter to apply the update.

mattermod avatar Dec 02 '21 14:12 mattermod

@dipak-demansol @DHaussermann Is this PR ready to be merged?

hanzei avatar Mar 01 '22 12:03 hanzei

@dipak-demansol @DHaussermann Is this PR ready to be merged?

@hanzei can you pls update this master branch with original master using the /update-branch, then will check the issue that i mentioned here https://github.com/mattermost/mattermost-plugin-github/pull/476#issuecomment-981661785 and then will update you about that ASAP.

dipak-demansol avatar Mar 01 '22 12:03 dipak-demansol

Looks like you don't have permissions to trigger this command. Only available for the PR submitter and org members

mattermod avatar Mar 01 '22 12:03 mattermod

/update-branch

hanzei avatar Mar 01 '22 12:03 hanzei

We don't have permissions to update this PR, please contact the submitter to apply the update.

mattermod avatar Mar 01 '22 12:03 mattermod

@maisnamrajusingh Would you please merge master into this branch?

hanzei avatar Mar 01 '22 12:03 hanzei

I have fixed the linting errors so the PR looks ok for a merge pending final QA

maisnamrajusingh avatar Mar 31 '22 13:03 maisnamrajusingh

@maisnamrajusingh in create issue model after selecting the repo, Description data is removed. pls fix that issue.

dipak-demansol avatar Mar 31 '22 19:03 dipak-demansol

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar May 09 '22 01:05 mattermod