try icon indicating copy to clipboard operation
try copied to clipboard

Package is not stateless, not concurrency-safe

Open ash2k opened this issue 8 years ago • 1 comments

It looks like it is not possible to use this package in several places with different values for MaxRetries. Also it is not concurrency safe to mutate this value if package is used from multiple goroutines - e.g. one might be setting MaxRetries value and another one will be reading without any synchronization.

ash2k avatar Apr 27 '17 04:04 ash2k

That's true - would you like to submit a fix?

Sent from my iPhone

On 26 Apr 2017, at 21:30, Mikhail Mazurskiy [email protected] wrote:

It looks like it is not possible to use this package in several places with different values for MaxRetries. Also it is not concurrency safe to mutate this value if package is used from multiple goroutines - e.g. one might be setting MaxRetries value and another one will be reading without any synchronization.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

matryer avatar Apr 27 '17 05:04 matryer