matrixone icon indicating copy to clipboard operation
matrixone copied to clipboard
verified publisher icon matrixorigin

[Bug]: Standardize the behavior of tableDef, Resolve, GetHidekey and their definitions

Open nnsgmsone opened this issue 3 years ago • 1 comments

Is there an existing issue for the same bug?

  • [X] I have checked the existing issues.

Environment

- Version or commit-id (e.g. v0.1.0 or 8b23a93):
- Hardware parameters:
- OS type:
- Others:

Actual Behavior

Confusion

Expected Behavior

No response

Steps to Reproduce

No response

Additional information

No response

nnsgmsone avatar Oct 13 '22 01:10 nnsgmsone

The inteface of engine, TableDefs(), GetPrimaryKeys(), GetHideKeys() are unclear definition.Need to refactor its behavior, suggest adding TableColumns() to return the definition of all columns(mo_columns). Also show create table suggests using query mo_tables and mo_columns directly.

nnsgmsone avatar Oct 13 '22 01:10 nnsgmsone

@nnsgmsone could u pls test it at the latest commit and update the issue status, thx

sukki37 avatar Oct 29 '22 05:10 sukki37

start to do it this week @aunjgr

florashi181 avatar Nov 04 '22 03:11 florashi181

Has discussed this with @ouyuanning and decided to start it after v0.6 is finished. The refactorization will involve many parts, so too dangerous to touch it now.

aunjgr avatar Nov 07 '22 19:11 aunjgr

Redesign of TableDef has been finished. Separate constraints will be migrated one by one, and should be tracked by separate issues.

This one can be closed.

aunjgr avatar Jan 03 '23 07:01 aunjgr