matrix-org
Support custom emoji in editor and completions.
This change implements custom inline emojis as specified in https://github.com/matrix-org/matrix-spec-proposals/pull/2545 in the editor and autocompletion suggestions. This does not implement a UI for configuring room image sets, but element users may be in rooms with image sets that were set up in other clients such as Fluffy Chat.
The emoji picker will be updated in a separate pr.
Signed-off-by: Andrew Ryan [email protected]
Here's what your changelog entry will look like:
✨ Features
- Support custom emoji in editor and completions. (#8087). Contributed by @AndrewRyanChama.
@turt2live what would the next steps be fore a product or design review? Should I submit a request somehwere?
This PR is in the product review queue, but the product team will likely want to scope out an approach to custom emoji as a whole before they would consider this change, so be prepared to wait.
From a product perspective, I'm generally in favor of us moving forward with this PR. There is actually a real business use case where the employees of enterprise customers do like to take photos of their coworkers and turn them into emoji memes and use them in this manner.
The only thing that I would caution here is that we need to use this PR to push for the finishing of the work on MSC2545. I'd hate to see us implement this feature only to have it not make spec within a reasonable amount of time after implementation.
Karl Abbott Product Manager, Element
fwiw, from the spec side there are far greater concerns than this PR could ever cause 😅 We'll be taking a look at it from the SCT side to de-risk it (custom emoji is currently slated as the next big client feature after threads).
@AndrewRyanChama is this PR still active? We want to consolidate the amount of competing PRs in order for the feature to move forward. Product is blocking #9240 since they have to review all competing PRs that are open. If not, please close this PR so https://github.com/matrix-org/matrix-react-sdk/pull/9240 can go forward.
@JiffyCat I have contacted the owner of this PR (@AndrewRyanChama). He has said he is not going to work on this anymore. Specifically:
I don't have any interest in contributing to element anymore at all, and that includes doing housekeeping tasks such as closing or updating old prs you can quote me on that
This PR can be assumed closed.
