matrix-org
Copy formatted text to clipboard on selecting chat
Fixes https://github.com/vector-im/element-web/issues/19726 Fixes https://github.com/vector-im/element-web/issues/17844 Fixes https://github.com/vector-im/element-web/issues/893
Writes an irc style log to the clipboard on selecting and copying chat.
https://user-images.githubusercontent.com/65661241/143228747-b0b7037d-8e0f-47a3-831f-133c9de81721.mp4
Here's what your changelog entry will look like:
✨ Features
- Copy formatted text to clipboard on selecting chat (#7192). Fixes vector-im/element-web#19726 vector-im/element-web#17844 and vector-im/element-web#893. Contributed by @jaiwanth-v.
Preview: https://61a0cfde0b1968681b0d1619--matrix-react-sdk.netlify.app ⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.
I have a feeling there is an issue that should be fixed by this, can't find it though
I've asked the design team to take a look at this. Code-wise, after a brief look, it looks pretty sane to me.
Thanks for working on this!
I had a quick chat with the team and apparently this is something @ara4n has asked for over a reasonably long period of time.
https://github.com/vector-im/element-web/issues/19726 being the latest issue ~~(but I doubt the only)~~ https://github.com/vector-im/element-web/issues/893 being the older
Looks like some type check is complaining @jaiwanth-v
@andybalaam it should be fixed now.
@andybalaam it should be fixed now.
Yep. Let's see what @janogarcia says about this, and then I'll get into reading the code properly.
@andybalaam it should be fixed now.
Yep. Let's see what @janogarcia says about this, and then I'll get into reading the code properly.
Just to be clear, definitely want this feature and thanks @jaiwanth-v for putting it together.
From design @janogarcia would be great to just get quick sense checks and suggestions on the format of the text (date formats, where to use commas vs hyphens vs brackets, etc).
Huh? Why did GitHub automagically request a review? I didn't press any buttons…
Putting this to draft while I am working on it.
Unfortunately the base code has changed in the meantime. After updating this PR to the current develop, the feature does not seem to work any more. @jaiwanth-v thank you for putting the work into this. Can you have another look at this PR? I've also moved this PR to draft until it is ready to be reviewed again.