complement icon indicating copy to clipboard operation
complement copied to clipboard

Sytest: Add `30rooms/60version_upgrade` tests

Open ShadowJonathan opened this issue 3 years ago • 4 comments

This adds 6 sytests:

  • ./tests/30rooms/60version_upgrade.pl: test "$user_type user has push rules copied to upgraded room",
  • ./tests/30rooms/60version_upgrade.pl:test "/upgrade creates a new room",
  • ./tests/30rooms/60version_upgrade.pl:test "/upgrade moves aliases to the new room",
  • ./tests/30rooms/60version_upgrade.pl:test "/upgrade is rejected if the user can't send state events",
  • ./tests/30rooms/60version_upgrade.pl:test "/upgrade of a bogus room fails gracefully",
  • ./tests/30rooms/60version_upgrade.pl:test "/upgrade to an unknown version is rejected",

However, this also ignores the remaining 13 sytests, due to non-formalisation of what they're testing for in the spec, see https://github.com/matrix-org/matrix-spec/issues/1324 and https://github.com/matrix-org/matrix-spec/issues/456 for more details on that.

This also adds some extra logging in MustSyncUntil to make it clear which checker exactly it is printing errors for, this is useful when the errors inside the checker itself are ambiguous or not helpful with identifying the checker.

ShadowJonathan avatar Nov 10 '22 10:11 ShadowJonathan

CI is failing because of https://github.com/matrix-org/complement/pull/550, will merge/rebase after that is merged

ShadowJonathan avatar Nov 10 '22 10:11 ShadowJonathan

CI is failing because of #550, will merge/rebase after that is merged

CI seems to still be failing @ShadowJonathan , is that expected?

clokep avatar Nov 28 '22 19:11 clokep

@clokep those are unrelated flakes, could you kick off a rerun?

ShadowJonathan avatar Nov 29 '22 10:11 ShadowJonathan

I did another rerun and this is green.

DMRobertson avatar Dec 02 '22 18:12 DMRobertson

Closing as stale.

kegsay avatar Sep 06 '24 08:09 kegsay