ipympl icon indicating copy to clipboard operation
ipympl copied to clipboard

Starting testing latest ipywidgets + remove `<8` pin

Open ianhi opened this issue 3 years ago • 5 comments

Should fix #460

ianhi avatar Apr 15 '22 16:04 ianhi

Binder :point_left: Launch a binder notebook on branch ianhi/ipympl/widgets8

github-actions[bot] avatar Apr 15 '22 16:04 github-actions[bot]

@martinRenou I consolidated a lot of the tests because we were spending a lot of time waiting for conda envs to install so i figured we could save on that by just having build and test steps. Is there a reason that we should instead keep the separate?

ianhi avatar Apr 15 '22 18:04 ianhi

Is there a reason that we should instead keep the separate?

The idea behind this is to test the generated wheel while running the tests. Though I am not strongly against getting rid of it.

martinRenou avatar Apr 19 '22 17:04 martinRenou

Is there a reason that we should instead keep the separate?

The idea behind this is to test the generated wheel while running the tests. Though I am not strongly against getting rid of it.

I think that that behavior was is maintained here - we still have a separate build and test step. I meant that the pytest tests and the visual regression tests were split into different steps which resulted in extra full installs

ianhi avatar Apr 19 '22 17:04 ianhi

notes for myself:

Check out the matrix of jupyterlab dependencies. Part of the issue may be due to this:

          - python: '3.6'
            dist: 'ipympl*.tar.gz'
            jlab_version: 3
          - python: '3.9'
            dist: 'ipympl*.whl'
            jlab_version: 2.3.2

there's also this warning: LOG Run-time JupyterLab version (3.3.4) is different than testing framework is built for (3.0.11). This could cause issues in testing.

ianhi avatar Apr 20 '22 16:04 ianhi

We need to update Galata quite a bit probably. I'll do this in this PR if it does not pass the tests.

martinRenou avatar Aug 19 '22 07:08 martinRenou

The failing tests are the ones against Matplotlib's main branch, so we can ignore them for now and fix those later.

martinRenou avatar Aug 19 '22 09:08 martinRenou

Please update galata references

martinRenou avatar Aug 22 '22 08:08 martinRenou

Bot running in https://github.com/matplotlib/ipympl/actions/runs/2902499214

martinRenou avatar Aug 22 '22 08:08 martinRenou

I removed the JupyterLab 2 CI test, as it's quite old anyway now and it reduces our build matrix.

As said above, the tests against latest Matplotlib are failing, let's ignore those for now.

Merging!

martinRenou avatar Aug 22 '22 09:08 martinRenou

thank you martin!

ianhi avatar Aug 22 '22 16:08 ianhi