cycler icon indicating copy to clipboard operation
cycler copied to clipboard

ENH: add helpers to merge extra data into a cycler instance

Open tacaswell opened this issue 7 years ago • 4 comments

From private discussions with @weathergod

This still needs:

  • is this actually a good idea to include?
  • tests
  • make sure it is in the docs + example

tacaswell avatar Apr 23 '18 19:04 tacaswell

Codecov Report

Merging #47 into master will decrease coverage by 1.58%. The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage     100%   98.41%   -1.59%     
==========================================
  Files           1        1              
  Lines         184      189       +5     
  Branches       51       53       +2     
==========================================
+ Hits          184      186       +2     
- Misses          0        3       +3
Impacted Files Coverage Δ
cycler.py 98.41% <40%> (-1.59%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1dc2965...5f00bec. Read the comment docs.

codecov-io avatar Apr 23 '18 19:04 codecov-io

@WeatherGod took 18 months, but I addressed your comments!

tacaswell avatar Sep 13 '19 23:09 tacaswell

Is there a reason these are stand alone functions? I would have expected

  • a class method Cycler.from_dicts
  • an instance method Cycler.merge_supplemental

timhoffm avatar Sep 14 '19 07:09 timhoffm

@timhoffm Fair, but I think that one level of nesting cycler.Cycler.from_dicts and neither function needs access to the class object.

Still not sure this is a good idea. Maybe this should just go into the docs as an example?

tacaswell avatar Sep 18 '19 07:09 tacaswell