ENH: add helpers to merge extra data into a cycler instance
From private discussions with @weathergod
This still needs:
- is this actually a good idea to include?
- tests
- make sure it is in the docs + example
Codecov Report
Merging #47 into master will decrease coverage by
1.58%. The diff coverage is40%.
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 100% 98.41% -1.59%
==========================================
Files 1 1
Lines 184 189 +5
Branches 51 53 +2
==========================================
+ Hits 184 186 +2
- Misses 0 3 +3
| Impacted Files | Coverage Δ | |
|---|---|---|
| cycler.py | 98.41% <40%> (-1.59%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 1dc2965...5f00bec. Read the comment docs.
@WeatherGod took 18 months, but I addressed your comments!
Is there a reason these are stand alone functions? I would have expected
- a class method
Cycler.from_dicts - an instance method
Cycler.merge_supplemental
@timhoffm Fair, but I think that one level of nesting cycler.Cycler.from_dicts and neither function needs access to the class object.
Still not sure this is a good idea. Maybe this should just go into the docs as an example?