cmocean icon indicating copy to clipboard operation
cmocean copied to clipboard

Minor fixes

Open ocefpaf opened this issue 1 year ago • 4 comments

I was chasing a red-herring due to a bad pinned version in an environment and ended up adding more Pythons to the test matrix here. No need code, just boilerplate updates.

ocefpaf avatar Jul 23 '24 16:07 ocefpaf

@ocefpaf Is some of this the new way to do packaging, in particular removing the setup.* files? Stresses me out. Did you do it correctly?

kthyng avatar Jul 26 '24 21:07 kthyng

@ocefpaf Is some of this the new way to do packaging, in particular removing the setup.* files?

Yes. See https://peps.python.org/pep-0518/ and https://peps.python.org/pep-0517/ for more info. Python packaging rarely requires a setup.py nowadays.

Stresses me out. Did you do it correctly?

Sorry for the stress. Feel free to close it. Regarding correctness. We can add a packaging tests here, build sdist and wheel for upload, to ensure things work.

ocefpaf avatar Jul 29 '24 08:07 ocefpaf

Sorry for the stress. Feel free to close it. Regarding correctness. We can add a packaging tests here, build sdist and wheel for upload, to ensure things work.

No! That's not what I meant, I meant that I don't feel in a good position to check it and it always feels a bit like magic. You're right, a test would be a good way! And thanks for the resources, I need to keep updating my understanding of how things work.

kthyng avatar Aug 05 '24 15:08 kthyng

You're right, a test would be a good way!

The release GitHub Actions now:

  • checks the sdist
  • checks wheel
  • checks the manifest
  • installs and run the tests for the wheel

That should help avoid any regressions.

ocefpaf avatar Aug 05 '24 16:08 ocefpaf