plugin-SecurityInfo icon indicating copy to clipboard operation
plugin-SecurityInfo copied to clipboard

Add a test version.php for PHP7.3

Open ZerooCool opened this issue 6 years ago • 5 comments

The Json file https://github.com/ZerooCool/phpsecinfo/blob/phpsecinfo-zeroocool-v0.2.1/20070406-phpsecinfo-v0.2.1/.version.json

The file version.php https://github.com/ZerooCool/phpsecinfo/blob/phpsecinfo-zeroocool-v0.2.1/20070406-phpsecinfo-v0.2.1/PhpSecInfo/Test/Core/version.php

I change it for PHP 7.3 value.

ZerooCool avatar Aug 11 '19 02:08 ZerooCool

Can you create a PR for that? That'd be great

tsteur avatar Aug 12 '19 01:08 tsteur

Only those with write access to this repository can merge pull requests.

patch-1 + patch-2

ZerooCool avatar Aug 14 '19 13:08 ZerooCool

I don't really understand the use of this new test and hardcoding the version information. This test already checks for the latest version https://github.com/matomo-org/plugin-SecurityInfo/blob/e5994c355d0a4cb502749e2085b9ed67c9d4e282/PhpSecInfo/Test/Application/php.php

And if you dislike deserializing data, you could also simply use https://www.php.net/releases/?json=1&version=7

Findus23 avatar Aug 14 '19 13:08 Findus23

BTW: We can ping external URLs only if \Piwik\SettingsPiwik::isInternetEnabled() is enabled

tsteur avatar Aug 14 '19 21:08 tsteur

Then use relative link ?

ZerooCool avatar Aug 15 '19 02:08 ZerooCool