nightfall-sdk
nightfall-sdk copied to clipboard
Review User SDK unit tests and overall code coverage
Final look at User SDK tests.
- [ ] Client tests: interceptor, balances,
saveCommitments - [ ] Take a look at commitments tests in general
- [ ] MetaMask changes (rename eth keys test suit as accounts)
- [ ] Take a look at transaction tests mocking
submitTransaction - [ ] Improve coverage for
approveTransaction - [ ] Improve coverage for
tokenclass
Not worth addressing as we may migrate to ethers:
- web3Websocket
- submit
I have updated the issue. I would rather have smaller issues that cover different use cases or stories, e.g. #14. Each including their own tests.
Hey team! Please add your planning poker estimate with ZenHub @imagobea @luizoamorim