nightfall-sdk icon indicating copy to clipboard operation
nightfall-sdk copied to clipboard
verified publisher icon maticnetwork

Review User SDK unit tests and overall code coverage

Open druiz0992 opened this issue 3 years ago • 2 comments

Final look at User SDK tests.

  • [ ] Client tests: interceptor, balances, saveCommitments
  • [ ] Take a look at commitments tests in general
  • [ ] MetaMask changes (rename eth keys test suit as accounts)
  • [ ] Take a look at transaction tests mocking submitTransaction
  • [ ] Improve coverage for approveTransaction
  • [ ] Improve coverage for token class

Not worth addressing as we may migrate to ethers:

  • web3Websocket
  • submit

druiz0992 avatar Jun 02 '22 07:06 druiz0992

I have updated the issue. I would rather have smaller issues that cover different use cases or stories, e.g. #14. Each including their own tests.

imagobea avatar Jun 03 '22 09:06 imagobea

Hey team! Please add your planning poker estimate with ZenHub @imagobea @luizoamorim

imagobea avatar Jul 05 '22 15:07 imagobea