geth upstream v1.16.4

[marcello33]

Description

Merge geth upstream v1.16.4.

Block height for Osaka related code to be enabled and activated (as previously done for Madhugiri).

Changes

• [ ] Bugfix (non-breaking change that solves an issue)
• [ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
• [x] New feature (non-breaking change that adds functionality)
• [ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
• [ ] Changes only for a subset of nodes

Checklist

• [x] I have added at least 2 reviewer or the whole pos-v1 team
• [x] I have added sufficient documentation in code
• [x] I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
• [ ] Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
• [ ] Includes RPC methods changes, and the Notion documentation has been updated

Testing

• [x] I have added unit tests
• [ ] I have added tests to CI
• [x] I have tested this code manually on local environment
• [x] I have tested this code manually on remote devnet using express-cli
• [ ] I have tested this code manually on amoy
• [ ] I have created new e2e tests into express-cli

[codecov[bot]]

Codecov Report

:x: Patch coverage is 40.44600% with 1362 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.11%. Comparing base (c1e1773) to head (0c0c008). :warning: Report is 336 commits behind head on develop.

Files with missing lines	Patch %	Lines
core/state/state_sizer.go	51.93%	192 Missing and 19 partials :warning:
core/rawdb/database.go	0.00%	176 Missing :warning:
core/txpool/blobpool/blobpool.go	32.30%	168 Missing and 8 partials :warning:
core/types/bal/bal_encoding_rlp_generated.go	52.63%	78 Missing and 39 partials :warning:
core/types/bal/bal.go	0.00%	81 Missing :warning:
core/types/bal/bal_encoding.go	67.51%	54 Missing and 10 partials :warning:
core/rawdb/ancienttest/testsuite.go	0.00%	57 Missing :warning:
core/overlay/state_transition.go	0.00%	47 Missing :warning:
core/txpool/blobpool/conversion.go	59.63%	39 Missing and 5 partials :warning:
core/txpool/blobpool/slotter.go	26.41%	38 Missing and 1 partial :warning:
... and 55 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1839      +/-   ##
===========================================
- Coverage    48.19%   48.11%   -0.09%     
===========================================
  Files          827      867      +40     
  Lines       135906   147116   +11210     
===========================================
+ Hits         65497    70781    +5284     
- Misses       66182    71607    +5425     
- Partials      4227     4728     +501     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
341 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.3% Duplication on New Code

See analysis details on SonarQube Cloud