dockview icon indicating copy to clipboard operation
dockview copied to clipboard

feat: make sure panel vue component be child of DockViewVue component

Open chuyuandu opened this issue 1 year ago • 3 comments

In vue3 project register multi Vue3 panel component component instance is not child of DockViewVue instance, so provide/inject feature lost use teleport to render component to target, keep vue component instance tree structure.

chuyuandu avatar Jul 31 '24 10:07 chuyuandu

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 38323d9429d54f9bef62cbda6296b6297472774a:

Sandbox Source
customheader-dockview Configuration
dockview-app Configuration
editor-gridview Configuration
events-dockview Configuration
externaldnd-dockview Configuration
fullwidthtab-dockview Configuration
iframe-dockview Configuration
keyboard-dockview Configuration
lockedgroup-dockview Configuration
nativeapp-dockview Configuration
nested-dockview Configuration
rendering-dockview Configuration

codesandbox-ci[bot] avatar Jul 31 '24 10:07 codesandbox-ci[bot]

I would need to check this logic at some point but the changes in dockviewComponent.ts - I don't think they are required?

mathuo avatar Aug 05 '24 20:08 mathuo

I would need to check this logic at some point but the changes in dockviewComponent.ts - I don't think they are required?

when i use teleport to render panel component, the rightHeaderActionsComponents's props revieve params, params.group is a proxy object some logic will fail using ===, so i change to compare the group id

chuyuandu avatar Aug 06 '24 02:08 chuyuandu