feat(snackbar): Add dismiss button
- Add property
dismissible(default false) to avoid BC - Update related test
- Update related screenshot
Related issue: #933
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Codecov Report
Merging #999 into master will increase coverage by
<.01%. The diff coverage is100%.
@@ Coverage Diff @@
## master #999 +/- ##
==========================================
+ Coverage 94.13% 94.14% +<.01%
==========================================
Files 86 86
Lines 3649 3654 +5
Branches 578 581 +3
==========================================
+ Hits 3435 3440 +5
Misses 90 90
Partials 124 124
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/snackbar/index.tsx | 97.29% <100%> (+0.19%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 7cf30b6...9554a48. Read the comment docs.