material-components-web-react icon indicating copy to clipboard operation
material-components-web-react copied to clipboard

feat(snackbar): Add dismiss button

Open emri99 opened this issue 6 years ago • 4 comments

  • Add property dismissible (default false) to avoid BC
  • Update related test
  • Update related screenshot

Related issue: #933

emri99 avatar Sep 16 '19 11:09 emri99

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Sep 16 '19 11:09 googlebot

@googlebot I signed it!

emri99 avatar Sep 16 '19 11:09 emri99

Codecov Report

Merging #999 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
+ Coverage   94.13%   94.14%   +<.01%     
==========================================
  Files          86       86              
  Lines        3649     3654       +5     
  Branches      578      581       +3     
==========================================
+ Hits         3435     3440       +5     
  Misses         90       90              
  Partials      124      124
Impacted Files Coverage Δ
packages/snackbar/index.tsx 97.29% <100%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7cf30b6...9554a48. Read the comment docs.

codecov-io avatar Sep 16 '19 11:09 codecov-io

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Sep 16 '19 11:09 googlebot