react-native-action-button icon indicating copy to clipboard operation
react-native-action-button copied to clipboard

Crashes React Native 0.69.x

Open Nantris opened this issue 3 years ago • 7 comments

The line that fails is buttonTextStyle: Text.propTypes.style,

@mastermoo, would you be open to accepting a PR for this issue? I would make one, but I don't want to bother if there's no chance of acceptance.

Nantris avatar Aug 19 '22 00:08 Nantris

It's not working on expo v46, I think it's related.

LucasPMM avatar Sep 05 '22 21:09 LucasPMM

@LucasPMM you can use patch-package to disable that line. It's not Expo, but rather the new version of React Native: https://github.com/facebook/react-native/issues/33557

I found it basically impossible to upgrade without relying on patch-package.

I'd still be open to submitting a PR to fix this, but if @mastermoo isn't around to accept it, then meh.

Nantris avatar Sep 05 '22 23:09 Nantris

I have the same error with 70.x version. You can solve the error with only one line. However, it does not bring to make a new pull request. Because the maintainer does not respond anyway.

It is time to make a new package with the whole pull request!

Does anyone want to participate in the team on the package?

approached avatar Oct 20 '22 11:10 approached

@approached that's probably a good idea since componentWillReceiveProps is used in the code, which is long deprecated. Replacing that single function, plus fixing this issue and #339 would bring everything up to speed I think.

Nantris avatar Oct 29 '22 00:10 Nantris

same problem on 70.x, waiting for the solution ~

Shin1122 avatar Nov 04 '22 15:11 Shin1122

@Shin1122 this repo is unmaintained. Use patch-package to comment out lines that contain references to Text.propTypes or ViewPropTypes

Nantris avatar Nov 04 '22 20:11 Nantris