react-native-action-button icon indicating copy to clipboard operation
react-native-action-button copied to clipboard

offsetY={n} crops from top by n

Open IgorVanian opened this issue 7 years ago • 2 comments

When using offsetY, the button is going up from bottom as expected, but the top part of the screen is padded by the same offset. So I get bottom padding AND top padding at the same time and it crops any items that are rendered above.

image

IgorVanian avatar Mar 07 '18 11:03 IgorVanian

I found this:

  getOffsetXY() {
    return {
      // paddingHorizontal: this.props.offsetX,
      paddingVertical: this.props.offsetY
    };
  }

In fact paddingVertical is a shortcut for both paddingTop AND paddingBottom. Replaced it by paddingBottom and it works fine now.

IgorVanian avatar Mar 07 '18 11:03 IgorVanian

Great. Happy to merge a PR fixing this issue

mastermoo avatar Jul 04 '18 17:07 mastermoo