marvin-ai
Read project dependencies from requirements.txt instead of mannualy typing into file
Instead of manually typing every project dependency wouldn't it be better if the dependencies were extracted from the environment using pip freeze > requirements.txt as it is done widely in python community?
Hi @marcossilva actually you can use the requirements.txt in your engine.
To do that you just have to change the Makefile from:
pip install -e . --process-dependency-links (in both marvin and update tasks)
to
pip install -r requirements.txt --process-dependency-links
and put -e . in the first line of your requirements.txt file
We prefer to use just setup.py to manage the dependencies because is the way that pypi manages the dependencies, turning the generated engine a little more standardised.
But this is just a default state, as you see you can change this easily.
Regards, Taka
I believe both ways are valid.
It would be great if the engine makefile could handle both. We could have an if statement to check if the requirements.txt file exists and then run the appropriated command. On Wed, 28 Feb 2018 at 19:27 Daniel Martins Takabayashi < [email protected]> wrote:
Hi @marcossilva https://github.com/marcossilva actually you can use the requirements.txt in your engine.
To do that you just have to change the Makefile from:
pip install -e . --process-dependency-links (in both marvin and update tasks)
to
pip install -r requirements.txt --process-dependency-links
and put -e . in the first line of your requirements.txt file
We prefer to use just setup.py to manage the dependencies because is the way that pypi manages the dependencies, turning the generated engine a little more standardised https://packaging.python.org/tutorials/distributing-packages/.
But this is just a default state, as you see you can change this easily.
Regards, Taka
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/marvin-ai/marvin-python-toolbox/issues/60#issuecomment-369405433, or mute the thread https://github.com/notifications/unsubscribe-auth/AFVjL2YfRPqXU8ZsypYWRM5hKNZNEXlxks5tZdK-gaJpZM4SRCr2 .
