martin

Results 162 comments of martin

Found [this bug](https://github.com/immich-app/immich/issues/3113) with this feature, is it normal ?

> Can we add notifications for each action such as favorite, and archive? Sure ! Do you want a notifications only when the shortcut is pressed ?

I added notifications for favorite and download, it's already implemented for archive.

Should we add a notification even for navigation actions (such as go to explore tab) ?

[Dang](https://github.com/imagegenius/docker-immich/commit/b6a24bb5d783adbf33a95c103abf2dfc28c6545a#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557L34). Sorry for the trouble everyone, will be fixed with https://github.com/imagegenius/docker-immich/pull/149

> I think it is fine to add keyboard shortcuts, but we should do it in a way that doesn't make the site less accessible (which is the outcome of...

Right, I think it should be clear in the WebUI what you can modify and what you can't. > In my opinion, a partner share should be near equivalent to...

The logic to stack assets already exist in https://github.com/immich-app/immich/blob/main/web/src/lib/components/photos-page/actions/stack-action.svelte. Can you use the same logic for the menu option and the shortcut action ?

> I think the rotation direction as currently implemented in this PR is actually reversed. Typically "rotate left" means counter-clockwise and "rotate right" would be clockwise. Indeed, thanks