react-css-transition-replace icon indicating copy to clipboard operation
react-css-transition-replace copied to clipboard

Remove deprecated findDOMNode? (like react-transition-group just did)

Open justingrant opened this issue 5 years ago • 4 comments

react-css-transition-replace shows warnings in Strict Mode, complaining about a deprecated API findDOMNode. Here's an example warning that shows in the console:

image

react-transition-group used to have the same problem, but as of react-transition-group 4.4.0 this API usage was removed and replaced with a ref-based solution.

Can react-css-transition-replace do something similar too?

justingrant avatar May 08 '20 05:05 justingrant

I see it's been a while since this was opened. I support this and will either do it in due course or accept a PR for it. I will be happy with a complete removal of findDOMNode, and then there can be a major version update for this change.

marnusw avatar Jan 30 '21 14:01 marnusw

It would be awesome if this could be implemented. This components works amazingly, but this error is indeed quite jarring (let alone not really future-proof).

robertwubs avatar Mar 31 '21 23:03 robertwubs

Thanks. Please submit a PR if you need this urgently. Since react-transition-group offers a template implementation it should be pretty straightforward.

marnusw avatar Apr 01 '21 05:04 marnusw

PR created https://github.com/marnusw/react-css-transition-replace/pull/101

Dagur avatar Jul 12 '22 15:07 Dagur

Hello @marnusw, would you mind merging this PR and releasing a new version together with the other React 18 related changes? This would be great! Thanks a lot!

santosch avatar Jan 19 '23 16:01 santosch

Thanks @Dagur and for the note @santosch. I must have missed the PR when it was first created. Sorry about the wait. I'll get to this in the next few days.

marnusw avatar Jan 31 '23 11:01 marnusw

Released in 5.0.0-beta.0 via #101

marnusw avatar Feb 08 '23 12:02 marnusw