react-admin icon indicating copy to clipboard operation
react-admin copied to clipboard

Add the ability to disable title configuration (while still make the rest of the page configurable)

Open smeng9 opened this issue 2 years ago • 8 comments

Is your feature request related to a problem? Please describe. The documentation of AppBar says https://marmelab.com/react-admin/AppBar.html#configurable

By default, users can override the page title in configurable mode.

But did not suggest a way to turn it off while keeping the rest of the page configurable.

Describe the solution you'd like

I would like the <Title /> component to accept a boolean prop called nonconfigurable, so user can optionally disable it

Describe alternatives you've considered

The alternative is developer has to manually change list, show, create and import additional react functions to render PageTitle into a portal.

smeng9 avatar Mar 29 '23 08:03 smeng9

I agree, we should allow to disable this feature while still allowing other parts of the app to be configurable. Would you like to open a PR?

slax57 avatar Mar 29 '23 12:03 slax57

Hi, Can I work on this?

ujjwalpandey922 avatar Apr 03 '23 05:04 ujjwalpandey922

@ujjwalpandey922 Of course! :slightly_smiling_face: Just remember to read the Contribution Guidelines first, and to target your PR against the next branch as it's a new feature. Thanks!

slax57 avatar Apr 03 '23 08:04 slax57

@smeng9 is this issue still open ? i will like to contribute towards it

Aditay2002 avatar Jun 27 '23 20:06 Aditay2002

@Aditay2002 yes the issue is still open, you can go ahead :slightly_smiling_face: Thanks

slax57 avatar Jun 28 '23 13:06 slax57

Hi, is anyone still working on this issue? If not I'd like to give it a try.

Mex7180 avatar Apr 19 '24 10:04 Mex7180

Hi @Mex7180, it appears no one is working on this issue yet. So yes, you can give a try! Don't forget to read our Contribution Guidelines first, and to target your PR against the next branch. Thanks for your contribution :pray:

adguernier avatar Apr 22 '24 09:04 adguernier

I have a pull request: https://github.com/marmelab/react-admin/pull/9836 that attempts to tackle this issue. Would appreciate a review, thanks!

markyao6275 avatar May 08 '24 01:05 markyao6275

Implemented in https://github.com/marmelab/react-admin/pull/9836

slax57 avatar Jun 28 '24 14:06 slax57