Mark Molinaro

icon indicating a website link https://www.linkedin.com/in/markjm-1/

icon company @pinterest icon location Seattle, WA

Results 21 comments of Mark Molinaro

SNC missing first property in PropertyAccessExpression

Actually a simpler case: ``` type C = string | null; const C1: C = null as C; const y: string = C1; ``` does not yield any changes. Perhaps...

Poor performance with big project

Hi @alexander-akait - one perf issue we are facing in our larger project is the `stats.toJson()` call. I am using the below patch, and everything seems to be working just...

perf: utilize throwIfNoEntry in sync mode

Thanks @sokra - mind publishing a new version w this change?

Ensure we respect inline comments

Perhaps worth noting that inline comments have been confirmed to be supported and are now included as an example in the docs https://docs.github.com/en/enterprise-cloud@latest/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners (search for inline)

fix: #543 more properly identify CREATE TABLE ... LIKE ... statements

cc @reata who opened the relevant issue and @andialbrecht as the maintainer of this awesome project :)

fix: #543 more properly identify CREATE TABLE ... LIKE ... statements

@andialbrecht resolved merge conflicts with recently merged https://github.com/andialbrecht/sqlparse/issues/740

fix: #543 more properly identify CREATE TABLE ... LIKE ... statements

Hi @andialbrecht just wanted to check in on this change. Is this something you would be interested in incorporating? If so, i can keep the branch conflict-free

fix hack to check if register_buffer has been overridden

@pytorchbot label "topic: not user facing"

fix hack to check if register_buffer has been overridden

thanks @mikaylagawarecki - ill watch the test suite then look to fixup mypy (or maybe ignore? not 100% sure how to make mypy know this will have the `__func__` property)....

fix hack to check if register_buffer has been overridden

@Skylion007 i changed to `getattr` approach before your comment, but am happy to change to whichever approach you prefer