python-react icon indicating copy to clipboard operation
python-react copied to clipboard

Python 3.4+ / Django 1.8+ support

Open eb-emilio opened this issue 5 years ago • 5 comments

Is there any plan to run travis on newer versions of Python and Django?

python:
  - "2.7"
  - "3.4"

env:
  - DJANGO_VERSION=1.7.8
  - DJANGO_VERSION=1.8.1

Code is not Python 3.7 compatible at least because it is calling unicode which is not available.

I volunteer to add this support in a pull request if you are interested.

eb-emilio avatar Aug 14 '20 00:08 eb-emilio

Sure, sounds good 👍

I think the code should function in both py2 and py3 as the unicode call is wrapped in __unicode__ which would only get called on py2. That being said maybe there's something in 3.7 that I'm not aware of 🤷

markfinger avatar Aug 16 '20 22:08 markfinger

Closed by #94

markfinger avatar Sep 14 '20 22:09 markfinger

Looks like there are some compatibility issues: https://github.com/markfinger/python-react/pull/94.

We'll need to figure out what we're aiming to support.

Python

I'm happy to drop py2 support. Internally we've got a few projects still running on it, but they're largely in a slow-maintenance / legacy mode.

Django

From https://www.djangoproject.com/download/, it looks Django 3.x and Django 2.2 are still supported. Recommend we consolidate on those.

markfinger avatar Sep 14 '20 23:09 markfinger

@eb-emilio any qualms if we switch the travis config to something like

python:
  - "3.8"

env:
  - DJANGO_VERSION=2.2.16
  - DJANGO_VERSION=3.1.1

markfinger avatar Sep 14 '20 23:09 markfinger

@markfinger yes, that makes sense. Sorry about that. We are on the same boat on legacy apps but it sounds good to stop testing Python 2.x and Django 1.x since they don't have support anymore.

eb-emilio avatar Sep 15 '20 14:09 eb-emilio