nohm icon indicating copy to clipboard operation
nohm copied to clipboard

Remove void return type for propertyDiff()

Open rak3n opened this issue 3 years ago • 2 comments

for issue #186

  • Add undefined check on onePropertyDiff return value, so as to return empty array from propertyDiff.

rak3n avatar Oct 24 '22 07:10 rak3n

Hey @maritz, many thanks for reviewing, have added test and dropped void from return type. This will modify the way propertyDiff is used in older code to handle no differences in property for a key, so I think it will be a major bump.

rak3n avatar Oct 26 '22 13:10 rak3n

This will modify the way propertyDiff is used in older code to handle no differences in property for a key, so I think it will be a major bump.

Yeah, I was thinking so as well. I'm kind of hesitant to just publish a v3 only for this rather minimal change. But on the other hand I can't really promise when other bigger changes are coming.

I guess I'll add this and some dependency updates into a v3 soon and not hold it up for other stuff.

maritz avatar Oct 26 '22 22:10 maritz