node-db icon indicating copy to clipboard operation
node-db copied to clipboard

delete uv_work_t at end of callback

Open steve-lawson opened this issue 11 years ago • 2 comments

Found a small memory leak.

steve-lawson avatar May 16 '14 13:05 steve-lawson

Nice catch! Wouldn't it be better to delete the request from Execute itself instead of ExecuteFinished. Since request was created here, it probably makes more sense to delete it here

mariano avatar May 16 '14 14:05 mariano

I think that request needs to stay around until the callback finishes, then it is deleted here, but req created here was not being deleted?

steve-lawson avatar May 16 '14 14:05 steve-lawson