react-native-quick-crypto icon indicating copy to clipboard operation
react-native-quick-crypto copied to clipboard

[email protected] build failed

Open YutaSugimura opened this issue 3 years ago • 5 comments

Description

Build failed when updating react-native version to 0.70.0

iOS

screen-shot 2022-09-06 12 48 06

Android

/Users/user1/rn/node_modules/react-native-quick-crypto/cpp/Cipher/MGLCipherHostObject.cpp:454:24: error: no member named 'throwJSError' in namespace 'facebook::jsi::detail'

/Users/user1/rn/node_modules/react-native-quick-crypto/cpp/Cipher/MGLCipherHostObject.cpp:470:24: error: no member named 'throwJSError' in namespace 'facebook::jsi::detail'

/Users/user1/rn/node_modules/react-native-quick-crypto/cpp/Cipher/MGLCipherHostObject.cpp:505:24: error: no member named 'throwJSError' in namespace 'facebook::jsi::detail'

YutaSugimura avatar Sep 06 '22 05:09 YutaSugimura

I'm also facing same issue

informsharique avatar Sep 06 '22 21:09 informsharique

dsshard avatar Sep 06 '22 22:09 dsshard

Related issue here. Using the exact same steps from a RN 69.5 template ([email protected]) on latest version on RN 70.0 yields build error when running yarn ios.

Tail of the build log on my M1 macbook air:

** BUILD FAILED **


The following build commands failed:
        CompileC /Users/elliotsayes/Library/Developer/Xcode/DerivedData/RN700-cgpinprkvhngpdbgrmijdfsfdvuh/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-quick-crypto.build/Objects-normal/arm64/MGLRsa.o /Users/elliotsayes/Code/ReactNative/Test/RN700/node_modules/react-native-quick-crypto/cpp/Cipher/MGLRsa.cpp normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'react-native-quick-crypto' from project 'Pods')
(1 failure)

elliotsayes avatar Sep 07 '22 10:09 elliotsayes

I was able to get it to compile by replacing all instances of throwJSError with throwOrDiejsi::JSError

paulingalls avatar Sep 10 '22 17:09 paulingalls

following @paulingalls instructions find: jsi::detail::throwJSError replace: jsi::detail::throwOrDie<jsi::JSError>

forked here: https://github.com/ArweaveNative/react-native-quick-crypto/tree/rn701 compiling on m1 @ RN 0.70.1

To use it:

npx react-native init RN701_patch --template react-native-template-typescript
cd RN701_patch
yarn add ArweaveNative/react-native-quick-crypto#built/rn701
yarn add react-native-quick-base64
npx pod-install

update your babel.config.js or metro.config.js and then yarn ios

elliotsayes avatar Sep 19 '22 23:09 elliotsayes

Any update on this?

PadovaY avatar Sep 29 '22 07:09 PadovaY

@PadovaY just use my fork above if you need this fix asap

elliotsayes avatar Sep 29 '22 07:09 elliotsayes