zolastrap icon indicating copy to clipboard operation
zolastrap copied to clipboard

Hardcoded icon `fab` option which prevents generic icon usage

Open QueenOfSquiggles opened this issue 1 year ago • 6 comments

In templates/base.html:189

          ><i class="fab fa-{{icon.icon}}"></i></a>

the hardcoded template configuration prevents customization of icons. For example, I want to add an RSS "branded" icon to my blog footer, but doing so would require finding an associate brand icon as per Bootstrap's Icon Search

For now I'm probably just going to fork with this change (basically requiring branded icons to prefix the "fab fa-" with the icon (which may be less usable for beginners, but is fairly intuitive for me since I can just copy & paste from the search bootstrap provides)

QueenOfSquiggles avatar Aug 24 '24 13:08 QueenOfSquiggles

Yes you are absolutely right.

I apologize for my mistake.

I'm a lone developer and it's very difficult to keep up with everything.

marcodpt avatar Aug 24 '24 18:08 marcodpt

Absolutely no worries! I'm solo for 99% of what I make. If you wanna copy anything from my fork back into this, feel free :heart:

QueenOfSquiggles avatar Aug 24 '24 20:08 QueenOfSquiggles

If you want to send a pull request I will accept it immediately.

marcodpt avatar Aug 24 '24 21:08 marcodpt

I've made quite a few of customizing changes as well :sweat_smile:

But if you've looked it over and like my changes I'll do that

QueenOfSquiggles avatar Aug 25 '24 12:08 QueenOfSquiggles

My customizations are running on my blog if you want to see what it looks like live: https://queenofsquiggles.github.io/

QueenOfSquiggles avatar Aug 25 '24 12:08 QueenOfSquiggles

All good,

I think it's risky to bring your modifications here.

It can break many things that are working.

Anyway, thank you very much for the feedback, when I change this repository I will copy what you did.

marcodpt avatar Aug 25 '24 14:08 marcodpt