react-skylight icon indicating copy to clipboard operation
react-skylight copied to clipboard

Warnings with React 16.9.0

Open NicoleRauch opened this issue 6 years ago • 1 comments

Hello, I just updated to React 16.9.0, and now I am seeing the following warning:

react-dom.development.js:11495 Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.
* Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: SkyLightStateless

Could you please have a look into this and make react-skylight compatible with the newest versions of React? Thanks!

NicoleRauch avatar Aug 18 '19 00:08 NicoleRauch

@marcio I submitted a pull request to replace the functions

https://github.com/marcio/react-skylight/pull/84

nzayatz14 avatar Aug 26 '19 15:08 nzayatz14