android icon indicating copy to clipboard operation
android copied to clipboard

Upgrade Dagger Dependency

Open sarahcodes100 opened this issue 8 years ago • 5 comments

We are on 2.0 but at the time of writing the newest version is 2.11

https://github.com/google/dagger/releases

sarahcodes100 avatar Sep 13 '17 20:09 sarahcodes100

Could you reopen this Issue? It is not possible to downgrade Dagger to version 2.0 in my project. And with v2.11 the mapzen library will not build.

My app is also using the kotlin annotation processor and the mapzen library is using the default gradle annotation processor. This combination is failing at the moment.

BaN4NaJ0e avatar Oct 09 '17 13:10 BaN4NaJ0e

@BaN4NaJ0e Thanks for the 👍 to this work. Now that we have v1.6.1 out the door, we're going to be going through and upgrading all dependencies to latest versions.

I've created #479 to track the separate but likely related issue for the kotlin annotation processor build failures. Reopening the previous issue would only cause for confusion :)

msmollin avatar Oct 09 '17 16:10 msmollin

As a workaround for now I have build the mapzen sdk by myself. I have updated the dagger version inside the MapZen SDK to v2.12 and replaced the annotationProcessor with the Kotlin kapt version. So far everything seems to work. So you guys should have no problems to update all dependencies to latest versions too.

Looking forward for a new MapZen SDK release with the latest depencies. ;) Keep up the good work!

BaN4NaJ0e avatar Oct 23 '17 11:10 BaN4NaJ0e

@BaN4NaJ0e fantastic! Would you want to submit that as a PR?

msmollin avatar Oct 23 '17 18:10 msmollin

All I did was changing the version numbers inside the build.gradle file and added the Kotlin Annotation Processor. So instead of writing:

annotationProcessor 'com.google.dagger:dagger-compiler:2.0'

I changed it to:

kapt 'com.google.dagger:dagger-compiler:2.11'

Do not forget to add the Kotlin Stuff at the top of the build gradle file:

apply plugin: 'kotlin-android' apply plugin: 'kotlin-kapt'

That was all!

BaN4NaJ0e avatar Oct 24 '17 15:10 BaN4NaJ0e