mapstruct-idea icon indicating copy to clipboard operation
mapstruct-idea copied to clipboard

Quick fixes - Fix all '...' problems in file

Open mkrumpholz opened this issue 5 years ago • 2 comments

With the quick fix there comes the "Fix all 'Unmapped target properties' problems in file" option. But this only fixes the selected target property and not all as it should. Also it is not clear if fix all means add all or ignore all properties.

  1. the fix all should go through the list of all similar problems
  2. all similar should make a difference between add and ignore, depending on what menu entry was selected

I recognized that there is an "Ignore all unmapped target properties". That helps on the first level in the menu but the "Fix all..." in the submenu is also a common usage in IntelliJ IDEA. At least having the same for add would be a quick win while completing the implentation to Fix all later on.

mkrumpholz avatar Jun 30 '20 15:06 mkrumpholz

Thanks for the feedback @mkrumpholz.

The problem with the "Fix all..." is that it doesn't apply the selected quick fix as a solution for the fix all. Not sure how the "Fix all" works. The problem here is that there are 2 completely different possibilities for fixing all. It is either ignoring or adding a source and not sure whether you can influence the "Fix all...".

If you know how to do it then please share the info or provide a PR so we can improve this.

filiphr avatar Jul 04 '20 17:07 filiphr

Isn't there any context, meta info, properties or some other information about the selected entry on the first level in the quick fix menu? Some kind of parent or so? The it would be possible to differ between ignore and add.

I'm probably on the same level or less in plugin development like you: searching plugin dev docs or jetbrains forums on how to implement the required solution, maybe even debugging from the last known code deeper into IDEA's code. :smiley: As i didn't implement quick fixes i can't provide a solution, just knowing and using this quite often as a developer.

mkrumpholz avatar Jul 06 '20 07:07 mkrumpholz