mapmap icon indicating copy to clipboard operation
mapmap copied to clipboard

Simplify the iteration logic in OscInterface

Open aalex opened this issue 5 years ago • 1 comments

As developers, we want code that is easy to read, inderstand and maintain.

The logic for string tokenizing in OscInterface is quite convoluted. It would be useful to make it a lot simpler and easier to read.

It's not very clear what QPair<QString,QString> OscInterface::next(const QString& path) does. It splits a string into token. Instead, but one by one. Instead, we could very well write a static function that returns list of tokens. (instead of an iterator) Also, it doesn't need to be a member of that class. I think the code also needs more comments.

aalex avatar Apr 02 '20 14:04 aalex

I agree this code could really be improved.

sofian avatar Apr 02 '20 14:04 sofian