In MappingListModel and related classes, use of "Qt::CheckStateRole + xyz" is not appropriate

Open sofian opened this issue 9 years ago • 2 comments

Both "solo" and "locked" state are controlled by looking at role "Qt::CheckStateRole + " but this is not appropriate. I think the right approach is rather to use the index.column() option. However, as it is now, the code "works" but it is a "hack". Therefore we should fix it.

Mar 23 '16 22:03 sofian

Yes we should fix it and I agree with that but I think that if Qt here decided to jump between Qt::CheckStateRole = 10 and Qt::InitialSortOrderRole = 14 is because it allows to use the 11 12 and 13 numbers.

Mar 25 '16 12:03 baydam

All right in that case this is really low priority (probably wontfix actually). Let's leave it there but outside of milestones.

Mar 25 '16 21:03 sofian