mapillary-js icon indicating copy to clipboard operation
mapillary-js copied to clipboard

Not possible to add tags when viewer move promises resolve

Open oscarlorentzon opened this issue 7 years ago • 0 comments

Basic information

MapillaryJS version: 2.6.0 System/Browser: All

Steps to Reproduce Behavior

  1. Create a new viewer and activate the tag component
var viewer = new Mapillary.Viewer(..., '<original-image-key>');
viewer.activateComponent('tag');
var tagComponent = viewer.getComponent('tag');
  1. Move to a new key at a later point in time and set a tag related to the new image key
viewer.moveToKey('<tag-image-key>')
    .then(
        function(node) { 
            var tag = new Mapillary.TagComponent.OutlineTag(...);
            tagComponent.add(tag);
        });

Expected behavior

The tag is rendered correctly according to its geometry coordinates.

Actual behavior

The tag position will be related to the original-image-key and rendered incorrectly.

Additional information

To be able to render tags correctly, one has to use the Mapillary.Viewer.nodechanged event and add the tags related to a certain image key after that event has fired for that particular key.

oscarlorentzon avatar Aug 02 '18 08:08 oscarlorentzon