OpenSfM icon indicating copy to clipboard operation
OpenSfM copied to clipboard

Do you need the in-tree copy of gtest?

Open SomeoneSerge opened this issue 3 years ago • 0 comments

The distributed FindGlog.cmake and FindGtest.cmake diverge from the upstream's interface: the modern gtest and glog seem to link through the targets glog::glog and GTest::gtest, whereas you rely on the GLOG_LIBRARY variable. This is somewhat of a hindrance when trying to build OpenSfM with system-distributed versions of gtest/glog and creates a necessity for patching the CMakeLists before the build: https://github.com/NixOS/nixpkgs/pull/152957/files#diff-393b1ae08ea4ab1b6c409e106cdf13ef1ac32d9777af6744bb895bfaf37b9346R52

Do you need the custom copy of gtest and custom Find* files in the first place?

SomeoneSerge avatar Feb 19 '22 14:02 SomeoneSerge