rio-toa icon indicating copy to clipboard operation
rio-toa copied to clipboard

Why does `reflectance` accept multiple source images and `radiance` does not?

Open j08lue opened this issue 8 years ago • 2 comments

reflectance takes a list of sources as input: https://github.com/mapbox/rio-toa/blob/0a40beb1bd3c05c76c65f2f20951591d831ad5ea/rio_toa/reflectance.py#L131-L137

while radiance takes just one and expects that it contains multiple bands: https://github.com/mapbox/rio-toa/blob/0a40beb1bd3c05c76c65f2f20951591d831ad5ea/rio_toa/radiance.py#L64-L70

Why the difference? It should be easy to get the same behaviour in radiance with the principle used in reflectance: https://github.com/mapbox/rio-toa/blob/0a40beb1bd3c05c76c65f2f20951591d831ad5ea/rio_toa/reflectance.py#L93-L96

If there is no real reason for having two different interfaces, I suggest we harmonize them.

j08lue avatar Nov 10 '17 10:11 j08lue

@j08lue thanks for the issue. I agree -- I don't think that there is any reason to not have them harmonized. Would you be able to submit a PR with the proposed change?

dnomadb avatar Nov 10 '17 19:11 dnomadb

@dnomadb thanks for the response. I will make a PR.

j08lue avatar Nov 13 '17 07:11 j08lue